elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

[Fleet] Add help text to Fleet policy output fields #148840

Open runejuhl opened 1 year ago

runejuhl commented 1 year ago

If the current license does not allow setting output the field is disabled. Before this patch no explanation as to why the field was disabled was shown, which was the cause of a bit of frustration.

This PR is completely untested and serves mostly as a suggestion for how it could be implemented.

See https://github.com/elastic/kibana/issues/148839.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

kibanamachine commented 1 year ago

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service[bot] commented 1 year ago

💚 CLA has been signed

juliaElastic commented 1 week ago

/ci

juliaElastic commented 1 week ago

Thanks for the contribution! The code looks good, I'll test it locally before approving.

elasticmachine commented 1 week ago

Pinging @elastic/fleet (Team:Fleet)

juliaElastic commented 1 week ago

/ci

kibana-ci commented 1 week ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.3MB 1.3MB +207.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

juliaElastic commented 2 days ago

It looks like unit tests are failing. Are you up for fixing them?