Closed roshan-elastic closed 1 year ago
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)
Just gonna leave a comment here about the placement and the button action. In the case that the expands the History, the button will move up with it. That seems a little clunky to me because the button seems attached to the history section.
Furthermore, it appears that the button will open the Dashboards in a new window by showing the popout
icon. I would recommend that it will go to the Dashboards link directly. So we can remove the popout
icon. I think we just show the new
badge and leave the button the same style, not depending on a click action from the user.
@kkurstak Happy to go over this in our sync tomorrow, just wanted to put my feedback in writing here as well 👍
Cheers @formgeist - input appreciated! Catching up with @kkurstak...
Hey @formgeist,
Just caught up with @kkurstak and one of the things I liked about the suggested icon is that it's indicating we're going out of 0lly. A little bit like what's going on here with the APM and Uptime links:
I wonder if there's a way that we can illustrate to the user that this is going to a separate part of the product (i.e. not make them think it's part of a seamless 011y experience)?
Will leave this with @kkurstak but that's one of the things I liked about the existing design...maybe there's a nice way to do that?
@roshan-elastic I understand that we want to express that this is "outside" the Observability solution, but it's still within Kibana, and we're deliberately linking to it as part of the experience.
The popout icon is meant to indicate a new window and an exit out of Kibana. The usage in the panel tabs is not consistent, but I understand this is meant to indicate a different interaction than clicking the rest of the tabs which would show the content in the panel content.
In the more recent design, those APM and Uptime options were actually moved into their own separate action buttons. We just never got them implemented that way 😊
Hope my feedback helps in why I think we shouldn't have the link show a popout - primarily because we shouldn't open it in a new window.
Cheers @formgeist. To confirm my understanding:
That correct? If so, OK with me!
This issue is ready
@kkurstak - could you check the top comment in this issue and fill in the bits with your name (updated designs)? Very minor.
I've spoken with @formgeist last Friday about this - the positioning of the link will stay as in this design. As for the icon - it will be suggesting the user is going "outside of" Observability - consistently with what's happening in other parts of the interface.
@kkurstak, just want to confirm if the position of the button remains the same when the visualization is switched to Table View.
@roshan-elastic , based on what I'm reading, the icon will stay. Could we remove this note to avoid confusion?
Note : Please remove 'new window' icon from this (@kkurstak - could you remove this from the design and update screenshot here? See @formgeist's https://github.com/elastic/kibana/issues/149616#issuecomment-1406561317)
Hey @crespocarlos - thanks for asking.
@kkurstak, just want to confirm if the position of the button remains the same when the visualization is switched to Table View.
Your call @kkurstak. I'd imagine it will stay the same?
based on what I'm reading, the icon will stay. Could we remove this note to avoid confusion? When we mentioned removing the icon, it's just removing the new window icon. The pink "TRY IT" badge only show the first time the user sees this. Once they've seen it once, the "TRY IT" will disappear.
Just gonna leave a comment here about the placement and the button action. In the case that the expands the History, the button will move up with it. That seems a little clunky to me because the button seems attached to the history section.
Not only will it move up, but the new buttons can overlap the waffle map
Hey, thanks for the mentions :) @crespocarlos, is there a way we could place the links on a white card component [extra small shadow], so the links [at least the once below] would travel on it and be always well-visible - what I mean:
@kkurstak , something like this?
https://user-images.githubusercontent.com/2767137/216331389-ec0bfb26-458b-4faa-a8e4-ccc954817887.mov
Yes, exactly :) Awesome @crespocarlos!
Oh man - that looks niccccccccccccce. Great team work you two!
Hey @crespocarlos - can we close this one out?
Hey @crespocarlos ,
Just realised that the 'k8s' dashboards link is showing even when 'hosts' are selected in the 'show' drop-down (rather than just when 'k8s pods' are selected):
If we wanted to have this only show when 'kubernetes pods' is selected, is this still possible (as a bug fix)? Should I create a bug and prioritise?
Sorry, I may have missed this in the preview videos...
@smith - Not sure on process here so just want to make sure I do this right
Good catch! I'll work on a fix for this. I'll create a ticket. Since it's bug fix, I assume we can backport it to 8.7
Bosh!
📖 Description
Assuming the k8s user clicks through to the k8s pods view, we will then show a generic k8s dashboards link through to the 'dashboards' list page pre-filtered for all k8s dashboards (the user may/may not have any but that's OK).
Dashboards link shows as pink the first time someone sees it
Once it has been seen once, it will revert to a blue colour as per the below:
Dashboards link returns to blue
✔️ Acceptance criteria
What must this feature have?
1. Must Have
Must be delivered in this issue in order for the release to be valuable
2. Should Have
I don't believe we need a specific custom event here - probably just the correct class so we can capture this in FS
*a.euiLink[class="accent"][data-test-subj="inventory-kubernetesDashboard-link"]**I don't believe we need a specific custom event here - probably just the correct class so we can capture this in FS
*.a.euiLink[class="primary"][data-test-subj="inventory-kubernetesDashboard-link"]**3. Could Have
Would be nice to have but not critical
4. Will Not Have (for now)
Explicitly will not be looked at within this issue