search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[APM] Storage explorer should display sampling rate as N/A if there are no tx #150302

Open dgieselaar opened 1 year ago

dgieselaar commented 1 year ago

Currently, the Storage Explorer displays a sampling rate of 0% if there are no transactions. This is misleading, as we can't actually infer what the sampling rate would be if there were transactions (which might not exist or might be dropped for whatever reason). We should instead display N/A. This would help the user (and us in the context of SDHs) establish more quickly that there are no transactions indexed into Elasticsearch.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/server/routes/storage_explorer/get_service_statistics.ts

elasticmachine commented 1 year ago

Pinging @elastic/apm-ui (Team:APM)

ArchitGajjar commented 10 months ago

Hi @dgieselaar can I work on this issue ? can you please assign this to me ? Thank you

elasticmachine commented 4 months ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

ArchitGajjar commented 2 months ago

HI @dgieselaar - I am currently working this issue, and testing through writing unit test cases. Can you please take a quick look and see if I am heading into the right directions ?

[DRAFT] PR - https://github.com/elastic/kibana/pull/191275

Also, can you please share how can I replicate this issue/experience in local environment ?

Thank you very much!