[Infrastructure UI] Give feedback about wrong formatted index-pattern after version upgrade

[mohamedhamed-ahmed]

Kibana version: < 8.5.3

Describe the bug:

Starting version 8.5.3 we added UI validations to prevent having spaces in the indices names as per this PR. A customer reported in this SDH not seeing data in the inventory view and after investigations, we found out that the settings view had a validation error that caused this behavior.

Steps to reproduce:

1. Create cloud deployment on version 8.1.1
2. Navigate to Inventory view and open the settings page
3. Add a new index with a leading space ex: metrics-system.
4. Notice how the UI allows having spaces in the index names
5. Save the new settings
6. Upgrade to version 8.5.3
7. Navigate again to the inventory settings view
8. Notice how the validation is now triggered but still has the leading space from an older version

Expected behavior:

As a customer, I would expect to clearly know that there is an issue with my settings view.

Suggestions:

• The issue needs to be fixed across all settings view such as inventory settings and logs settings pages to prevent this from happening for users upgrading from an older to a newer version.
• We can either trim these spaces on a response level
• Or create a shared component to validate the settings index patterns
• Other solutions are also possible here

[elasticmachine]

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

[tonyghiani]

In my understanding, the validation is correctly working on the client because it tells the user that adding trailing spaces is not allowed, limiting their chance to save a wrong index pattern that would break the whole inventory, since the related data view wouldn't be retrieved correctly.

Maybe the title misleads me, shouldn't this be something more about "Give feedback about wrong formatted index-pattern"? Or something similar to bring the user to double-check the settings?

[mohamedhamed-ahmed]

@tonyghiani It is not about the validations themselves but more about the visibility of the problem to the customer as described in the steps. So basically the validations work correctly it is just that the User is not aware that there is a problem that he needs to fix after upgrading from an older version A better title is a good idea I also had doubts about naming it :D

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[botelastic[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.