search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.61k stars 8.22k forks source link

[Discover] Improve Discover mobile loading UI #151503

Closed davismcphee closed 1 week ago

davismcphee commented 1 year ago

When loading Discover in mobile view, the Elastic logo is pinned to the left instead of centered as it is in Dashboard, for example. The grid also doesn't fill the available vertical space while loading which looks strange and makes the UI seem jumpy as it loads. We should make a couple style changes here to center the loading logo and fill the available vertical space while the grid loads: mobile_loading

elasticmachine commented 1 year ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal commented 2 months ago

This could be a nice issue for people starting to contribute to Kibana, because I think it just needs to make use of EuiEmptyPrompt with the loading spinner, removing EuiFlexGroup, EuiFlexItem

https://github.com/elastic/kibana/blob/537d812a56aeb233cacef68d704aaed61e79fac1/src/plugins/discover/public/components/common/loading_indicator.tsx#L17-L21

davismcphee commented 2 months ago

@kertal agreed, I added the good first issue label.

youhonglian commented 1 week ago

@kertal Can i pick this?