elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.13k forks source link

[APM] Add filters to tables showing summary of metrics in mobile transactions. #153668

Open MiriamAparicio opened 1 year ago

MiriamAparicio commented 1 year ago

Follow up from https://github.com/elastic/kibana/issues/146877

Add the filters to the tables, so the user can filter the table.

image

It should work similar to the filters we have for Instances, where we update the search bar.

image

image

Questions

image

elasticmachine commented 1 year ago

Pinging @elastic/apm-ui (Team:APM)

MiriamAparicio commented 1 year ago

Question for the refinement: I would expect, that because we already have the filters on the top, the filters on the table work differently, for example to be able to filter more than one row at the same time, but if we filter as the Instances table, the table we will filter out just the selected row

cc @akhileshpok @boriskirov

achyutjhunjhunwala commented 1 year ago

I believe all the filters we use on APM, affects the URL which means the top level filters. With Unified Search, we can either update the search bar with the selected filter from the table or add Pills, in either case, we will have to update the URL.

If we don't want to update the main search bar, we can create Pills like this

image
sorenlouv commented 1 year ago

Pills sounds like a good solution for ad-hoc filters.

If we already have a dedicated control (dropdown) we might want to update that instead of a adding a pill. This way we won't have the same dimension represented twice. However this does increase complexity.