Closed petrklapka closed 1 year ago
Pinging @elastic/appex-sharedux (Team:SharedUX)
There was an ask from the Security Solution team (@YulNaumenko) that the nav component package provide a way for solutions to import Platform navigation items, with the intention of placing them at-will within the Solution area and hiding them from the Platform area.
Example of how it would be used: Observability wants to show a link to Logs Anomalies from ML in the nav under Observability > Logs > Anomalies. The Anomalies link is in the Platform area of the nav under Machine Learning. Observability should hide the anomalies link under Machine Learning, and "import" that link so it can be showed in their solution area.
@tsullivan the capability to import individual items from the Platform area is something we need to have for MVP, but it's not a requirement for the first checkpoint. Should we start another issue with the remaining requirements so we can track them without adding scope to the initial work?
@rayafratkina I have created new issues to track progress, and each can be moved around or changed in priority as needed. The capability in question in tracked here: https://github.com/elastic/kibana/issues/154486 and we can have a separate discussion there about it.
I believe I was pinged by mistake, probably meant for @YulNaumenko
I've updated 20/35 of the checklist items to reflect the state of implementation in this (currently Draft) PR: https://github.com/elastic/kibana/pull/152510
The MVP Left Nav implementation for the April Integration checkpoint was delivered as a POC, then subsequently merged into main. Chrome polish tasks that remain are being tracked as separate issues.
The side navigation menu component is to be modified to meet the following needs in support of the Serverless Initiative.
1. Left nav
Appearance
[ ] The Left Nav menu shall adhere to the shown mockup in appearance.
It will be full-height and always appear in dark mode
[ ] It shall display the following groups
[x] It shall be possible for the Solution to hide each group. For example, if project type X only needs Discover and has provided it in their Solution IA/side nav, then they can hide the root level Data exploration/Analytics group (note: verify that this is technically feasible in initial build)
[x] For each group, specific child items may be hidden at the Solution team's discretion
[ ] Menu items that correspond to applications that are not enabled in the deployment shall not be rendered
[x] It shall support an icon and textual label for each root level menu item via
EuiCollapsibleNavGroup
docs[x] Root menu items shall support child menus via
EuiSideNav
docs[x] Root menu items shall be expandable/collapsible when they contain children via
EuiSideNav
docs[x] Child menu items shall consist only of textual labels and no icons (
EuiSideNav
support this, would we want/need to restrict what can be passed via the chrome service?)The expanded/collapsed state of the menu shall persist across user sessions (is this already supported via
localStorage
?)Root Level Menu Item Behavior
The root menu items defined above shall have the following behavior
Logo
Project Switcher
Home
Recents
Solution Menu
EuiCollapsibleNavGroup
EuiSideNav
components within the aforementionedEuiCollapsibleNavGroup
Analytics / Data exploration || Machine Learning || Dev Tools || Management
Additional Programmatic Functionality
This section defines additional behaviors and functionality required at a programmatic level that are not covered in the Appearance and Root Level Menu Behavior sections.
[ ] The top announcement banner shall continue to work as it does today (example below)
[ ] The bottom bars shall continue to work as they do today
Out of scope for April Checkpoint
(This is a general consensus as of writing; not set in stone)