elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.7k stars 8.12k forks source link

[AO] - Handle the deleted rule for an alert in the alert details page #157960

Open fkanout opened 1 year ago

fkanout commented 1 year ago

📝 Summary

If a rule is deleted and it has an active alert, the alert stays there, and by extension, the alert details page stays acceptable too. However, the rule is needed to fill up the alert details page.

If the user access the alert details page for an orphan alert (with deleted rule), the user will see only some basic info in the header, which is not a great user experience.

image

✅ ACs

It should cover all the alert detail pages (Latency, Metic, and Logs).

TBD cc @katrin-freihofner @maciejforcone @grabowskit

However, I see two options here:

  1. Show the info we have (header info) + show an error
  2. Showing an error message with no data at all.
elasticmachine commented 1 year ago

Pinging @elastic/actionable-observability (Team: Actionable Observability)

katrin-freihofner commented 1 year ago

What data do we have in this case? I guess some of it is also shown in the alerts table (depending on the column configuration)

fkanout commented 1 year ago

@katrin-freihofner, In a very raw way, this is what we have:

Screenshot 2023-05-17 at 19 00 35
maciejforcone commented 1 year ago

imho a user should get a clear message about what is going on (rule was deleted), and a way out. In this case I think the options could be:

Here is a mock:

image

and figma file

katrin-freihofner commented 1 year ago

A couple of thoughts:

  1. The wording in the status badge needs to be aligned with https://github.com/elastic/kibana/issues/159462
  2. The rule name should no longer be a link (according to Faisals comment we should have the name)
  3. Could we offer to delete the alert?
  4. We should involve a UX writer to help us with the wording. deleted-rule
maryam-saeidi commented 1 year ago
  1. The wording in the status badge needs to be aligned with [Recover life-cycle alerts when rule is

Since I used the badge that ResponseOps provided, when they add a new badge, it should also be shown automatically for us. (No need for a change on our side)

fkanout commented 1 year ago

@katrin-freihofner @maciejforcone, what do you think about adding a ⚠️ warning to this popup when the rule is Active (with active alerts)? The warning should say that the related alerts to this rule will be orphaned and they will stay Active.

Screenshot 2023-08-04 at 15 09 44