elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.66k stars 8.23k forks source link

[Security Solution] Cover rule snoozing functionality by automated tests #158196

Open maximpn opened 1 year ago

maximpn commented 1 year ago

Epics: https://github.com/elastic/kibana/issues/153633, https://github.com/elastic/security-team/issues/5308 (internal) Relates to: https://github.com/elastic/kibana/issues/147735, https://github.com/elastic/kibana/issues/155406, https://github.com/elastic/kibana/issues/147737, https://github.com/elastic/kibana/issues/147736

Summary

The rule snoozing feature adopted from Alerting Framework has to be properly tested. Add automated tests to cover the functionality.

Todo

elasticmachine commented 1 year ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine commented 1 year ago

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror commented 1 year ago

Should be resolved by https://github.com/elastic/kibana/pull/158195 @maximpn Is there anything else left to do regarding the test coverage, besides https://github.com/elastic/kibana/issues/159349?

maximpn commented 1 year ago

Is there anything else left to do regarding the test coverage, besides https://github.com/elastic/kibana/issues/159349?

@banderror the following cases and scenarios aren't covered by https://github.com/elastic/kibana/pull/158195

banderror commented 1 year ago

I see, thanks for the info @maximpn. I think we should increase the coverage in the 8.10 cycle. Let's keep the ticket open.