search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Dashboard] Welcome page shown when dashboard with ad-hoc data view exists #159628

Closed stephmilovic closed 3 weeks ago

stephmilovic commented 1 year ago

Kibana version: main/8.9

Elasticsearch version: main/8.9

Original install method (e.g. download page, yum, from source, etc.): Run es from snapshot and kibana locally

Describe the bug:

We have added behavior to install a dashboard when a certain type of connector is created: https://github.com/elastic/kibana/pull/159075

Starting with a fresh ES, no dashboards or data views. Creating the connector creates the dashboard. However, when we click the link to the dashboard from the connector, the dashboard app takes me to a "Welcome to Analytics! Add your data to get started, ..." empty page. Now add a data view on anything. After adding the data view, the link works, and the dashboard page shows the dashboard, instead of the "Welcome to Analytics" page.

Our GenAI Dashboard uses an ad-hoc data view.

Seems like that welcome page is driven off whether there are data views, but it should be based on whether there are dashboards. Can we please fix this?

Steps to reproduce:

  1. Starting with a fresh ES, no dashboards or data views
  2. Creating a GenAI connector
  3. Open the GenAI Connector edit view from a superuser account
  4. Click the link to the dashboard
  5. Notice Welcome page is shown

Expected behavior: Dashboard should be shown

elasticmachine commented 1 year ago

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

elasticmachine commented 1 year ago

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson commented 1 year ago

You're correct that this logic is based on if there is a data view present. This is a shared UX component and a common pattern in other apps. This was added here based on this meta issue. I think that potentially rather than changing this to check if there are any Dashboards, the data view check should be extended to also check for ad-hoc data views.

elasticmachine commented 1 year ago

Pinging @elastic/appex-sharedux (Team:SharedUX)

ThomThomson commented 1 year ago

Reassigning to the shared UX team for now. Ideally this is something that could be fixed in the shared component!

kowalczyk-krzysztof commented 3 weeks ago

https://github.com/user-attachments/assets/aad605b6-6c42-4639-8fa5-4af84830403d

I tried to reproduce the issue locally on latest main branch. Couldn't reproduce it as the navigation works properly. I also tried navigating out of Connectors page and going back there manually and the link still works. Same for the Dashboards -> OpenAI Token Usage flow. It also works fine for Gemini and Amazon Bedrock (all GenAI related connectors). All tests were done on superuser account.

Closing the issue as it's fixed.