Scalability tests on Core's public APIs

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.48k stars 8.04k forks source link

Scalability tests on Core's public APIs #159659

Open afharo opened 1 year ago

afharo commented 1 year ago

We should aim for 100% coverage in Scalability tests on Core's public APIs.

This will help us understand where our bottlenecks are and make better-informed decisions on performance improvements.

Let's list here the most important APIs so we can start with something:

[x] Status API: GET /api/status #164864
[ ] Index page: GET /index.html
[ ] Bootstrap script: GET /bootstrap.js
[ ] ??

elasticmachine commented 1 year ago

Pinging @elastic/kibana-core (Team:Core)

pgayvallet commented 1 year ago

(probably something I should know, but!) How / where should those scalability test added, exactly?

afharo commented 1 year ago

@pgayvallet Sorry! I forgot to add the link to the relevant area of the code: https://github.com/elastic/kibana/tree/main/x-pack/test/scalability/apis

pgayvallet commented 1 year ago

We may want to add:

translations: GET /translations/{locale}.json
uiSettings: GET /api/kibana/settings

Now regarding savedObjects... We're directly dependant on ES performances and ES-Kib connectivity here, but we're still doing additional work, so it could make sense to add scalability tests for the base APIs, e.g

retrieving SOs: GET /api/saved_objects/{type}/{id}
creating SOs: POST /api/saved_objects/{type}/{id}
updating SOs: PUT /api/saved_objects/{type}/{id} (this one may be tricky because of concurrency / conflicts, not sure we can do it with the current system)

WDYT?