elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.77k stars 8.17k forks source link

[APM] Verify that UI is working as expected after _doc_count is added to transactions/spans #163036

Open dgieselaar opened 1 year ago

dgieselaar commented 1 year ago

There currently is an in-flight PR to set _doc_count for transactions and spans, so results on sampled data are automatically upscaled.

The expectation is that this should need no work from the UI, but we should verify. In summary, the changes are:

We should check the following:

Ideally we should also have some synthtrace tests. We currently have sampled(), but I suggest we replace that with count(n), which would set both {transaction,span}.representative_count and _doc_count to n.

elasticmachine commented 1 year ago

Pinging @elastic/apm-ui (Team:APM)

yngrdyn commented 1 year ago

Following yesterday discussion on how to show to the user something has changed in the Based on sample transactions tooltip

image

we could use a popover that component would allow us to place a link to documentation, the only thing is the visual styling is different from the tooltip we display now.