search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Console] Check that the endpoint name matches the filename for override definitions #163611

Open yuliacech opened 1 year ago

yuliacech commented 1 year ago

When loading the override files from this folder, the spec_definitions_service.ts relies on the filenames to match the generated definitions with the overrides (see here). Then both definitions are merged, but if the name of the endpoint differs in the content of the file, that can introduce wrong definitions mapping. The service code should check that the name of the endpoint in the file is the same as the file name. Possibly throw an error or warning if that happens to alert the dev team about this issue. See this PR that introduces the error in the override files and this commit that manually fixes that.

elasticmachine commented 1 year ago

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

elasticmachine commented 2 months ago

Pinging @elastic/kibana-management (Team:Kibana Management)