elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.5k stars 8.05k forks source link

[Security Solution] Highlighted fields with long values are hard to read #164814

Closed MadameSheema closed 10 months ago

MadameSheema commented 10 months ago

Describe the bug:

Screenshot 2023-08-25 at 11 21 34

It would be great if we can adjust the size of the table in order to avoid having just 1 letter in a different row.

elasticmachine commented 10 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 10 months ago

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

PhilippeOberti commented 10 months ago

@MadameSheema this is fixed in this PR, which will be available in BC3.

The decision was made to let the EuiTable manage the column on its own. Most of the time it will be 50-50 width for both column, but if a specific column has much longer text than the other, EuiTable will manage that internally.

Note: I applied the same logic to the PrevalenceDetails table (left panel). The last 4 columns (alert count, doc count, host prevalence and user prevalence) are fixed to a small percentage (because they're only numbers) and the first 2 columns (field and value) split the rest of the space (similarly to the highlighted fields table)

MadameSheema commented 10 months ago

Fixed on BC3.

MadameSheema commented 10 months ago

Re-opening since we still have some issues on BC3 in certain scenarios where the values are long. Pending to be validated on BC4 since this PR will fix/improve the situation.

MadameSheema commented 10 months ago

@PhilippeOberti please add the fixed label again once the PR is backported to 8.10, thanks!! 😊

PhilippeOberti commented 10 months ago

this PR fixes the issue, the backport is successful and the changes will be available in BC4

In the new implementation, the field and value colums both use 50% of the width

MadameSheema commented 10 months ago

Fixed on BC4!! :)