elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.66k stars 8.23k forks source link

[Cloud Security] Hide internal Fleet server host URL and ES Output #165251

Closed eyalkraft closed 9 months ago

eyalkraft commented 1 year ago

Motivation As part of Agentless CSPM we introduced Internal fleet server host url and internal ES output on serverless projects. This results with a confusing UX for serverless users using fleet.

Screenshot 2023-08-30 at 18 35 12

Definition of done

Implementation Proposal:

Out of scope

Related tasks/epics

elasticmachine commented 1 year ago

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

maxcold commented 1 year ago

prioritizing https://github.com/elastic/security-team/issues/7557 vs this one as the incorrect agent version is blocking the Cloudformation (and probably other methods from working) while this one is mostly confusing UX. Plus @CohenIdo seems to have started working on https://github.com/elastic/security-team/issues/7482#top which covers more or less the same problem. If we introduce is_internal or smth in one of the tasks, it should be straightforward to filter them in the fleet ui. @kfirpeled let me know if my reasoning is off

kfirpeled commented 1 year ago

@maxcold recently @CohenIdo suggested a fix to https://github.com/elastic/security-team/issues/7482 It appears we had many tickets on similar issue

Lets sync on that when you are available to understand what exactly is duplicated here

eyalkraft commented 1 year ago

These are not duplicate.

This issue has to do with Fleet UX, unrelated to cloudformation or even cloudsecurity

maxcold commented 1 year ago

@kfirpeled @eyalkraft The issues are related in the sense that here we want to hide the internal host and in https://github.com/elastic/security-team/issues/7482 we want this internal host not to be picked up for Cloudformation/ Cloud Shell params. True that these are separate issues in two different parts of Kibana, but my thinking was that depending on the implementation the logic of "ignoring" the internal host could have been shared. I will check the PR @CohenIdo created to see if my thinking makes sense. Anyway hiding the internal fleet server seems less critical than the incorrect agent version on our Cloudformation/Cloud Shell (https://github.com/elastic/security-team/issues/7557) that's why I want to fix the agent version first

kfirpeled commented 1 year ago

moved to blocked - waiting for agentless epic planning

maxcold commented 9 months ago

before we merge

we need to wait till both

are deployed to all envs of kibana in serverless