search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Dashboards] Dashboards should only have single React render tree #166214

Open thomasneirynck opened 1 year ago

thomasneirynck commented 1 year ago

Dashboards now are made up of a number of Embeddables. Each have their own render tree. For more efficient DOM manipulation, Dashboards should only have a single render tree.

This will cut down on progressive loading.

This is a micro-optimization but points at a foundational issue with the Embeddable system; Embeddables are not instances of ReactComponent. Most other UX building blocks in Kibana are ReactComponents.

elasticmachine commented 1 year ago

Pinging @elastic/kibana-presentation (Team:Presentation)

vadimkibana commented 1 year ago

A broader follow-up would be that the whole Kibana should be a single React render context.

ThomThomson commented 1 year ago

Giving this an extra large LOE because this is one of the primary goals of the Embeddables redesign. When I open issues for that, I will mark this as blocked.

thomasneirynck commented 8 months ago

Changing to in-progress, as Embeddable refactor is in progress

thomasneirynck commented 7 months ago

dupe of https://github.com/elastic/kibana/issues/167429