search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.51k stars 8.05k forks source link

[management][settings] Image-based settings cannot have a default value. #166578

Open clintandrewhall opened 10 months ago

clintandrewhall commented 10 months ago

The code for image-based settings in the advancedSettings plugin assumes that any image-based setting would never have a default value. We've continued that assumption in @kbn/management-settings-field-input.

This issue is meant to track this assumption, and fix this logic either in an upcoming refactor, or when Kibana starts setting an image-based setting to contain an image by default.

elasticmachine commented 10 months ago

Pinging @elastic/appex-sharedux (Team:SharedUX)

elasticmachine commented 10 months ago

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

vadimkibana commented 10 months ago

Triaging this with the team: how do you envision this @clintandrewhall? Where/how would a default image be used?

clintandrewhall commented 10 months ago

@vadimkibana It's not so much that this is an immediate problem, as we don't have a use case where there is a default image... at the moment. But if we were to, say, allow a default logo for an organization as part of a cloud/serverless deployment, these fields would essentially break.