elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[EDR Workflows] An empty note section is displayed when we do not add comments for the controlled Artifact Rollout if the policies tab is having only read privileges #168318

Closed muskangulati-qasource closed 10 months ago

muskangulati-qasource commented 11 months ago

Description: An empty note section is displayed when we do not add comments for the controlled Artifact Rollout if the policies tab is having only read privileges

Build Details:

VERSION: 8.11.0
BUILD: 67811
COMMIT: b8dc9b47eabdacfd73dde39196f2311eb83d0240

Browser Details: All

Preconditions:

  1. Kibana user should be logged in

Steps to Reproduce:

  1. Login to a fresh Kibana environment
  2. Navigate to the 'Policies' tab under the Manage section of Security
  3. For any policy, set the control protection rollout to a random date and keep the note section empty
  4. Create a custom role and user with the policy set to 'READ' privilege
  5. Navigate to the 'Policies' tab under the Manage section of Security
  6. Observe the empty note section

Actual Result: An empty note section is displayed when we do not add comments for the controlled Artifact Rollout if the policies tab is having only read privileges

Expected Result: The note section should not be displayed if it is empty

Screenshot: BugEmptyNote

Logs N/A

elasticmachine commented 11 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 11 months ago

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

muskangulati-qasource commented 11 months ago

@manishgupta-qasource please review!

dasansol92 commented 11 months ago

FYI: @szwarckonrad

manishgupta-qasource commented 11 months ago

Reviewed & assigned to @kevinlog

szwarckonrad commented 11 months ago

PR is up.

szwarckonrad commented 11 months ago

Merged to main, backporting to 8.11. Should be available in 8.11 BC3

muskangulati-qasource commented 10 months ago

Hi @szwarckonrad,

We tested this ticket on the latest 8.12.0-SNAPSHOT build and found the issue is now fixed. 🟢

Please find below the testing details:

Build details:

VERSION: 8.12.0
BUILD: 69073
COMMIT: 81685d4c5161a77cca43be67e2bd132b6da4391c

Observation: No empty section is displayed now if no comments are added for protection updates

Screenshot: 168318

Hence, we are closing this ticket and marking it as 'QA Validated'.

Thanks!!

muskangulati-qasource commented 7 months ago

Bug Conversion

Thanks!