elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.48k stars 8.04k forks source link

Integration should not be used as plural when zero/one integration is added to the policy #168584

Open muskangulati-qasource opened 9 months ago

muskangulati-qasource commented 9 months ago

Description: Integration should not be used as plural when zero/one integration is added to the policy

Build Details:

Version: 8.11.0
Commit: 636a8339cfad92998a5a5adb7be81e3546525ebf
Build: 67841

Browser Details: All

Steps to Reproduce:

  1. Create a Serverless project from the QA console platform
  2. Login into the same and navigate to the asset tab --> fleet tab
  3. Create a policy with no integration
  4. Click on 'Add agent' for the policy with no integration

Actual Result: Integration is used as plural when zero/one integration is added to the policy

Expected Result: Integration should not be used as plural when zero/one integration is added to the policy

Screenshot: FleetDefaultPolicy

Logs N/A

elasticmachine commented 9 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 9 months ago

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

muskangulati-qasource commented 9 months ago

@manishgupta-qasource please review!

manishgupta-qasource commented 9 months ago

Reviewed & assigned to @kevinlog

ashokaditya commented 9 months ago

@muskangulati-qasource Thanks for pointing this out. Although I feel the description of the action is generic and is okay to have plural hosts or agents in the info.

I do notice that the Enroll in Fleet radio descriptions are using singular nouns and that maybe updated to use plural as well to make everything consistent. I also notice that there's a typo error in Enroll in Fleet radio and it should say Enroll an Elastic Agent... instead of Enroll in Elastic Agent.... That could also be updated as part of the text update.

cc @kevinlog

kevinlog commented 8 months ago

removing from serverless project since it's not serverless specific