elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[UnifiedDataTable] Add support to Flyout Pagination in the UnifiedDataTable component #168619

Open opauloh opened 11 months ago

opauloh commented 11 months ago

Motivation

Currently, the UnifiedDataTable component doesn't provide a way to allow us to have Flyout Pagination controls, the primary goal is to implement that support in a way that Flyouts opened by the CloudSecurity DataTable have paginations, a secondary goal is to add that support in the shared UnifiedDataTable itself, so all consumers can enable Flyout pagination if desired.

Definition of done

Out of scope

Team tag

@elastic/kibana-cloud-security-posture

Related

169247

kfirpeled commented 7 months ago

moved to 8.14

opauloh commented 7 months ago

Update: It looks like Flyout Pagination is now supported by the Unified Data Table

Image

I'm going to confirm that information and we agreed in the Findings enhancement sync that we are going to prioritize this ticket in case in case the support is already implemented and we just need to "enable" it

opauloh commented 6 months ago

Update:

Flyout pagination is possible using the setExpandedDoc method, as currently implemented here by the DiscoverGridFlyout component, alternatively is also possible to use the Discover Flyout since it's possible to add custom tabs, this way we would get the benefits of having the Actions available in the Table tab.

kfirpeled commented 6 months ago

Hi Paulo, happy to hear there's a possibility to add the support for pagination through our flyout

this way we would get the benefits of having the Actions available in the Table tab.

I don't see how these actions are relevant to our use case. So in that case, would that be a limitation for us if we don't want to include that?

opauloh commented 6 months ago

If we use the DiscoverGridFlyout we get access to the paginations, Actions on the Header, and Actions on the Table

Screenshot 2024-03-14 at 11 58 04 AM

The compromise is that we can't customize the Title as we have today, and also that the Flyout doesn't have an overlay background.

Screenshot 2024-03-14 at 1 24 58 PM

I don't see how these actions are relevant to our use case. So in that case, would that be a limitation for us if we don't want to include that?

If the benefits are not appealing to include in our use case, it's best if we add the pagination to our flyout using the setExpandedDoc method than trying to disable the features we don't want to in the DiscoverGridFlyout, there's no limitation on handling the pagination ourselves.