elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[EDR Workflows] The error is not defined for the wrong date selected under the controlled artifact rollout for policy #168674

Closed muskangulati-qasource closed 11 months ago

muskangulati-qasource commented 1 year ago

Description: The error is not defined for the wrong date selected under the controlled artifact rollout for policy

Build Details:

VERSION: 8.11.0
BUILD: 67841
COMMIT: 636a8339cfad92998a5a5adb7be81e3546525ebf

Browser Details: All

Preconditions:

  1. Kibana user should be logged in

Steps to Reproduce:

  1. Login to a fresh Kibana environment
  2. Navigate to the 'Policies' tab under the Manage section of Security
  3. For any policy, disable automatic updates under Protection updates
  4. Click on the calendar to select any other month apart from the current month. Do not click on any date simply click on the UI for the policy and save the policy

Actual Result: The error is not defined for the wrong date selected under the controlled artifact rollout for policy

Expected Result: The error should be defined to select a valid date in the range defined

Screen Recording:

https://github.com/elastic/kibana/assets/60252716/f234400e-771d-4d63-8ea3-a97b8a3112cf

Logs N/A

elasticmachine commented 1 year ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 1 year ago

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

muskangulati-qasource commented 1 year ago

@manishgupta-qasource please review!

manishgupta-qasource commented 1 year ago

Reviewed & assigned to @kevinlog

kevinlog commented 1 year ago

I think it's clear from the UI that you cannot pick these dates and we fail to save as expected, so I don't think this a blocker, but we could improve the message.

@szwarckonrad is it simple to improve the error message? I know we have messages in the API handling, is it possible to get those to the toast?

szwarckonrad commented 1 year ago

This is how the EUI component works.

@kevinlog I can do two things here:

  1. Do nothing if the date that would otherwise be autoselected and keep the input at last selected valid option. test1

  2. Show error and block Submit button. test2

Thinking about it now, the second option doesn't make much sense 😆 . I'm leaning toward option #1.

kevinlog commented 1 year ago

@szwarckonrad I think option 1 looks good. We don't need to spend too much time on this as I think it's clear in the UI already that you can't select future dates.

szwarckonrad commented 1 year ago

Merged to main and backported to 8.11.

muskangulati-qasource commented 11 months ago

Hi @szwarckonrad,

We tested this ticket on the latest 8.12.0-SNAPSHOT build and found the issue is now fixed. 🟢

Please find below the testing details:

Build details:

VERSION: 8.12.0
BUILD: 69073
COMMIT: 81685d4c5161a77cca43be67e2bd132b6da4391c

Observation: The user is not able to select any older dates

Screen Recording:

https://github.com/elastic/kibana/assets/60252716/5901cb74-547d-4c8f-a68d-05f0ca9bfa7e

Hence, we are closing this ticket and marking it as 'QA Validated'.

Thanks!!

muskangulati-qasource commented 9 months ago

Bug Conversion

Thanks!