Closed muskangulati-qasource closed 11 months ago
Pinging @elastic/security-solution (Team: SecuritySolution)
Pinging @elastic/security-defend-workflows (Team:Defend Workflows)
@manishgupta-qasource please review!
Reviewed & assigned to @kevinlog
I think it's clear from the UI that you cannot pick these dates and we fail to save as expected, so I don't think this a blocker, but we could improve the message.
@szwarckonrad is it simple to improve the error message? I know we have messages in the API handling, is it possible to get those to the toast?
This is how the EUI component works.
@kevinlog I can do two things here:
Do nothing if the date that would otherwise be autoselected and keep the input at last selected valid option.
Show error and block Submit button.
Thinking about it now, the second option doesn't make much sense 😆 . I'm leaning toward option #1.
@szwarckonrad I think option 1 looks good. We don't need to spend too much time on this as I think it's clear in the UI already that you can't select future dates.
Merged to main and backported to 8.11.
Hi @szwarckonrad,
We tested this ticket on the latest 8.12.0-SNAPSHOT build and found the issue is now fixed. 🟢
Please find below the testing details:
Build details:
VERSION: 8.12.0
BUILD: 69073
COMMIT: 81685d4c5161a77cca43be67e2bd132b6da4391c
Observation: The user is not able to select any older dates
Screen Recording:
https://github.com/elastic/kibana/assets/60252716/5901cb74-547d-4c8f-a68d-05f0ca9bfa7e
Hence, we are closing this ticket and marking it as 'QA Validated'.
Thanks!!
Thanks!
Description: The error is not defined for the wrong date selected under the controlled artifact rollout for policy
Build Details:
Browser Details: All
Preconditions:
Steps to Reproduce:
Actual Result: The error is not defined for the wrong date selected under the controlled artifact rollout for policy
Expected Result: The error should be defined to select a valid date in the range defined
Screen Recording:
https://github.com/elastic/kibana/assets/60252716/f234400e-771d-4d63-8ea3-a97b8a3112cf
Logs N/A