elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.81k stars 8.2k forks source link

[Security Solution][ Server Less] wrong breadcrumb for os query app #169628

Open ghost opened 1 year ago

ghost commented 1 year ago

Describe the bug: wrong breadcrumb for os query app

Kibana/Elasticsearch Stack version Version: 8.12.0 Commit: b5aa3752557874033463bb55dc3ee23e08cb25c2 Build: 68329

Browser and Browser OS Version: Firefox for windows OS Version: 118.0.2

Elastic Endpoint Version: v8.12.0-preview

Original install method: None

Functional Area: OS Query

Initial Setup:

Steps to reproduce

Additional Result

https://github.com/elastic/kibana/assets/59917825/d9fb4052-8d35-43b3-92d9-8ac4e5f2e69f

Current Result

Expected behavior:

Screen-Cast:

https://github.com/elastic/kibana/assets/59917825/2b78d5b8-dbcd-478d-b769-72234e6ba26b

elasticmachine commented 1 year ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 1 year ago

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

kevinlog commented 1 year ago

Solution:

We need to call serverless?.setBreadcrumbs(breadcrumbs) , along with the regular chrome.setBreadcrumbs(breadcrumbs) here: https://github.com/elastic/kibana/blob/088bc0b96ffc9603173fb44d620da9f720431cb5/x-pack/plugins/osquery/public/common/hooks/use_breadcrumbs.tsx#L186

The long term fix is to unify the behavior to make chrome.setBreadcrumbs to work in Serverless, tracked here: https://github.com/elastic/kibana/pull/169513

Short term, we can fix by adding the serverless?.setBreadcrumbs

cc @semd - pulled this from slack, let me know if i missed any details