[Cloud Security] [Findings++ Phase 2] Add create detection rule to the CloudSecurityDataTable

opauloh commented 1 year ago

Motivation

Add an action item on the CloudSecurity DataTable that allows to quick "Create a detection rule"

Definition of done

[x] CloudSecurity DataTable shows after the Flyout a Popup Menu
[x] The Popup menu contains the option: "Create a detection rule"
[x] Clicking on the button should create a detection rule
[x] The button is disabled and shows a spinning component when the action is loading
[x] Once a rule is created the same toaster used by the create detection rule in the Flyout should open.
[x] This option should be available on Misconfiguration Findings and Vulnerabilities.

Out of scope

Related tasks/epics

Team tag

@elastic/kibana-cloud-security-posture

kfirpeled commented 6 months ago

@einatjacoby , @smriti0321 would you prefer us to have an icon to create the DE rule instead of the 3-dots and then opening the popover?

einatjacoby commented 6 months ago

Thanks! Questions, maybe for next phase, open to discussion, see bottom row of screens in this figma

I think it should be in the Benchmark rules table as well I like the idea of having an icon instead of the kebab but that's still in debate, especially since in the Benchmark rules table it'll be easier to add in a kebab at this point Also, I haven't prepared a special icon for it yet, meanwhile we can use listAdd

opauloh commented 2 months ago

Verified - QA - Serverless

VERSION: 8.16.0

BUILD: 78101

COMMIT: f51481d4d697ae23260d2b46ceae7545d3571e95

Misconfigurations

Vulnerabilities

elastic / kibana

[Cloud Security] [Findings++ Phase 2] Add create detection rule to the CloudSecurityDataTable #172195