search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.6k stars 8.21k forks source link

[Security Solution] Rule tags popover hides tags of prebuilt rules #173151

Open banderror opened 10 months ago

banderror commented 10 months ago

Summary

Location: Rule Management page, Rules table.

This popover is too narrow and many of the tags of prebuilt rules are not fully visible:

Screenshot 2023-12-11 at 14 40 13

@ARWNightingale:

we should probably still have a max character count or width right. I think increasing it by around 30-40% would be a huge improvement.

elasticmachine commented 10 months ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine commented 10 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

spong commented 10 months ago

FYI, there's been some core work around these popover widths from the viz team recently: https://github.com/elastic/kibana/pull/171573

Can use the @kbn-calculate-width-from-char-count package for getting a good width (up to the max that Alex mentioned), coupled with the new text truncation component where you can do middle word truncation, which is nice for these UI's since it lets you see the final portion of the field name.

Pretty sure some security fields will still max this out though, so nice to have a delayed hover tooltip or something so you can discern it from what appears to the be the exact same field below it :sweat_smile:

pborgonovi commented 3 months ago

Validated latest 8.15 BC:

image