elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.57k stars 8.09k forks source link

[CSPM] Unexpected behaviour in Add Agent Drawer Snippet #173829

Open romulets opened 8 months ago

romulets commented 8 months ago

Describe the bug:

The snippet inside the CSP Add Agent drawer is editable

Kibana/Elasticsearch Stack version: 8.12.0

Steps to reproduce:

  1. Add a new CSP integration (I added GCP Cloud Shell)
  2. Click in Add Agent
  3. Select the snippet and edit it

Current behavior:

Snippet is editable

Expected behavior:

Snippet should not be editable

Screenshots (if relevant):

https://github.com/elastic/kibana/assets/5350001/fa566a08-d94f-45e5-84e4-1c731f454f6a

elasticmachine commented 8 months ago

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

JordanSh commented 8 months ago

@smriti0321 @tinnytintin10 Please let us know what do you think is a good UI solution for this. From the top of my head I think adding an input field to change the relevant values inside the command box would be more intuitive for most users

smriti0321 commented 8 months ago

@JordanSh I like the idea of adding input field. I believe only Org_ID is the editable/user input field. Is that correct? Also, is this behaviour specific to GCP or across all clouds?