search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

[Saved searches][Saved queries] Renaming to avoid confusion #174144

Open stratoula opened 8 months ago

stratoula commented 8 months ago

Describe the feature:

At the moment we are using 2 terms that they are quite confusing:

- Saved searches: Saved searches is the Discover SO which is used to import a table in a dashboard or create a new agg based visualization. On the second case the only thing that is transferred from the SO is the KQL query / filters. The reason that this is used in agg based visualizations is because it is saved by reference which means that if someone updates the saved search the change will be propagated to the SOs which are referencing it. Saved searches have started being much more than they used to be and are going to store even more information when these 2 issues are going to land in Discover https://github.com/elastic/kibana/issues/167887, https://github.com/elastic/kibana/issues/167635. As a user I want to save my Discover view and share it to other users. So now this SO reflects mostly the Discover app and is much more than a saved search. The name should change to accommodate this. We don't need to change the SO type name, we did the same with the index patterns. We just need to decide the term and make the necessary changes in the UI. We should also think how we want to inform the users about this change

One good candidate can be Discover View.

- Saved queries: Saved queries are the Unified search SO. They contain information about the filters, KQL and time frame. The name is a bit confusing though, users can't understand the difference between the Discover SO and the Unified search SO. Also with saving ES|QL queries this can be even more confusing in the future. We should also rename them to something that makes more sense.

One good candidate can be Filter sets.

elasticmachine commented 8 months ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine commented 8 months ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

stratoula commented 8 months ago

cc @amyjtechwriter @ninoslavmiskovic @timductive

thomasneirynck commented 8 months ago

@stratoula is this just a rename in the UX?

I would caution against renaming. It breaks discontinuity with marginal benefit. E.g. the rename index-pattern -> data-view added more confusion than it resolved. Until we can rename SO-types, we then also have to maintain a new mental model which maps the visible-naming to the internal-naming.

Good docs and guides within the product should already go a long way of making these distinct concepts more understandable.

stratoula commented 8 months ago

@thomasneirynck yes. I understand the point you are raising but I am afraid that the confusion will be much bigger if we keep it as it is. We really need to take action imho. Unless the renaming is something we are expecting to be possible soonish. Is it? We can always mask the SO type on the saved objects management page and display the new name on the dropdown and keep the old name only inside the SO.

teresaalvarezsoler commented 3 days ago

I just removed the Visualizations team from this issue since this seems to be an ESQL/Discover team issue.