[Serverless] Tests for burn rate rule alerts

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.73k stars 8.14k forks source link

[Serverless] Tests for burn rate rule alerts #174160

Open mgiota opened 8 months ago

mgiota commented 8 months ago

🍒 Summary

As part of this issue, basic SLO tests where created. Current tests verify the successful creation of burn rate rule type. What is currently missing is the verification of triggering of an alert.

✅ Acceptance criteria

Update burn rate rule serverless tests to include a test that verifies the triggering of an alert when the configured criteria are met

elasticmachine commented 8 months ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

kdelemme commented 4 months ago

@jasonrhodes @mgiota The burn rate rule test is already asserting on the active alerting status: https://github.com/kdelemme/kibana/blob/main/x-pack/test_serverless/api_integration/test_suites/observability/burn_rate_rule/burn_rate_rule.ts#L274-L280

I think we can close?

jasonrhodes commented 3 months ago

Sounds reasonable, I will wait and let @mgiota weigh in to be sure, and then yes if so let's close.