[Security Solution]User is able to attach a duplicate timeline to a Case without Saving the timeline.

sukhwindersingh-qasource commented 10 months ago

Describe the bug: User is able to attach a duplicate timeline to a Case without Saving the timeline

Kibana/Elasticsearch Stack version

VERSION: 8.12.0 BC5 BUILD: 70053 COMMIT: db9b8921b37139cbb1e11d23f6381f655edeb72b

Browser and Browser OS Version: Firefox for windows OS Version: 121.0

Elastic Endpoint Version: N/A

Original install method: None

Functional Area: Timeline

Initial Setup:

None

Precondition

Saved timeline should be present on Timelines page

Steps to reproduce

Go to Security timeline
Click on the more options of the saved timeline.
Select Duplicate timeline
Now click attach to case button.
Attach the time to a new case or existed case

Actual Result :

User is able to attach a duplicate timeline to a Case without Saving the timeline.

Expected Result :

Duplicate timeline should not be attached to a case unless it is saved.

Additional Information

While adding duplicate timeline without saving it shows error no timeline id found

Screen-Cast :

https://github.com/elastic/kibana/assets/108654988/5e83bc9f-e569-445d-8a1a-97bf786c0e5a

elasticmachine commented 10 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

sukhwindersingh-qasource commented 10 months ago

@manishgupta-qasource Kindly review this Thanks !

manishgupta-qasource commented 10 months ago

Reviewed and assigned to @MadameSheema

elasticmachine commented 10 months ago

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine commented 10 months ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

michaelolo24 commented 8 months ago

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

PhilippeOberti commented 8 months ago

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

Chiming in as I fixed a similar bug (PR) a few weeks ago where users could favorite an unsaved timeline. I decided to prevent users from favoriting until the timeline would be saved. I feel like we need to be consistent as much as possible

janmonschke commented 8 months ago

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

Yep, that would make sense

logeekal commented 1 month ago

@janmonschke , Do you remember if you already worked on this bug?

janmonschke commented 1 month ago

@logeekal I did not work on this yet, iirc

elastic / kibana

[Security Solution]User is able to attach a duplicate timeline to a Case without Saving the timeline. #174733