[Dashboard] Make Edit and View Modes less visually distinct

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.49k stars 8.05k forks source link

[Dashboard] Make Edit and View Modes less visually distinct #175451

Open ThomThomson opened 5 months ago

ThomThomson commented 5 months ago

Problem

Related to #161047. Blocked by #151233.

Currently Dashboard edit and view modes are quite visually distinct. We want to align the different between the two view modes to make a more seamless transition between the modes.

To-Do's:

[ ] Hide title header bar when panel title is an empty string or hideTitle is true
[ ] Remove [No title] in edit mode when panel title is an empty string
[x] #184532
- Instead of changing padding between modes, we should set EuiIcon to empty in view mode

Because many users spend most of their time in edit mode, we should strive to make it look as visually appealing as view mode.

elasticmachine commented 5 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson commented 5 months ago

CC @stratoula @markov00 @gvnmagni

teresaalvarezsoler commented 5 months ago

Title bars are always shown - even if there is no title

IMHO, this is the most important thing to solve because when the panels are very short (mainly markdown and links panels) the content cannot be displayed in edit mode and it’s super annoying. For example:

ThomThomson commented 5 months ago

@teresaalvarezsoler 100% agreed. I think that if we did https://github.com/elastic/kibana/issues/151233 first, it might make this much easier, as we'd have a built in place for all of the info to go - i.e. the library notification, the custom time badge etc could all be made hover actions.

cqliu1 commented 2 months ago

I'm marking this issue blocked by #151233 because Devon's right that we need a place to show notifications/badges before we can get rid of the title bar.