elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.7k stars 8.24k forks source link

[Infra] Change the Alerts Table in the Hosts View #175677

Closed crespocarlos closed 10 months ago

crespocarlos commented 10 months ago

Summary

We want to modify the default display of the <AlertsStateTable /> in the hosts view

WIP best way to customize this.

The default columns will be:

Open clickin in Reason hide the View in App button from the flyout

Implementation hints

To customize the table columns we need to register a new table config with the alertsTableConfigurationRegistry from the rule. Here is an example of how to do that.

We need to be mindful about how to organize the code, in a way that's easy to register more table configurations. For that, we could follow this example.

AC

elasticmachine commented 10 months ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

kpatticha commented 10 months ago

Why do we customize, and what are the benefits?

crespocarlos commented 10 months ago

@kpatticha , the current table uses the observability config

This is what it currently looks like:

image

SREs would like it to show three additional columns host.name, kibana.alert.rule.name, kibana.alert.start. This will facilitate the investigation. We want to remove the eye icon because it redirects the user to the Inventory UI - and does a full page refresh.

Another aspect of the customization is to leave only the necessary options in the toolbar. An assumption the Enter fullscreen mode, for instance, might not needed in this context.

kpatticha commented 10 months ago

sorry, I didn't notice the 3 additional columns in the description.

SREs would like it to show three additional columns host.name, kibana.alert.rule.name, kibana.alert.start. This will facilitate the investigation.

  1. Before considering a custom table, it might be beneficial to communicate the feedback of kibana.alert.rule.name and kibana.alert.start to the management team. We can discuss adding these columns to the default table so everyone using it can benefit and things stay consistent.
  2. Regarding host.name, given that the name is already present in the reason message, could the SREs be looking for a specific functionality, such as sorting, or is there another purpose for emphasizing this column?

We want to remove the eye icon because it redirects the user to the Inventory UI - and does a full page refresh.

I'm not against the customization, I'm just trying to understand if the cost of maintaining a custom table justifies the value it brings.

crespocarlos commented 10 months ago

Before considering a custom table, it might be beneficial to communicate the feedback of kibana.alert.rule.name and kibana.alert.start to the management team. We can discuss adding these columns to the default table so everyone using it can benefit and things stay consistent.

Good callout @kpatticha . I'll check that.

Regarding host.name, given that the name is already present in the reason message, could the SREs be looking for specific functionality, such as sorting, or is there another purpose for emphasizing this column?

Having the host.name here without ways of filtering it might be as valuable as I first tought. Sorting wouldn't help so much and doesn't remove the need for having to paginate over the list. I'll check this too.

kpatticha commented 10 months ago

Related PRs for hiding the view in app https://github.com/elastic/kibana/pull/175441

kpatticha commented 10 months ago

Before considering a custom table, it might be beneficial to communicate the feedback of kibana.alert.rule.name and kibana.alert.start to the management team. We can discuss adding these columns to the default table so everyone using it can benefit and things stay consistent.

Good callout @kpatticha . I'll check that.

I could also help with that just lmk

crespocarlos commented 10 months ago

Related PRs for hiding the view in app #175441

Thanks! It seems like we need something less hardcoded there.

I could also help with that just lmk

Great!

crespocarlos commented 10 months ago

@kpatticha moved this back to refining, let's figure out how to best achieve what we need here.

crespocarlos commented 10 months ago

@roshan-elastic @kpatticha

As discussed, I'm closing this ticket out:

The Observability alerts table already provides the columns we wanted to add and the cost of creating custom configurations for the table is high

host.name - can be found in Group kibana.alert.rule.name - Rule Name kibana.alert.start - Triggered

image

Based on that, there is no need to create custom config to display the columns above.

We'll discuss in a separate ticket the customization of the View in App button.