elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

[ObsUx][Infra] Add feedback button: Anomalies tab on Asset details (flyout/page) #175793

Closed jennypavlova closed 6 months ago

jennypavlova commented 7 months ago

Summary

The user of the ML feature inside the asset details view (Anomalies Tab) should be able to give feedback about the feature. The goal is to add a feedback button to the anomalies tab:

image

Design

Not final still WIP https://github.com/elastic/kibana/issues/176148

AC

crespocarlos commented 7 months ago

@jennypavlova is this one ready?

jennypavlova commented 7 months ago

@crespocarlos Once we have the button position confirmed I will move it to ready ( I added a comment to the design issue)

jennypavlova commented 6 months ago

cc: @kkurstak I saw the design issue do you know if we want to change the position of this button or if we want to implement it like in the mock-up in the description

kkurstak commented 6 months ago

In case we want the feedback only for the Anomalies tab, I would recommend placing the button at the bottom of the flyout - so the content of the flyout would not be changed. It's really hard to get anything good between the tabs and the content. Same button would apply when there's no data. What do you think? I wonder only about the size of the button - we could make it for the fly-out maybe small size [32px instead of 40px]. cc @roshan-elastic @jennypavlova @MiriamAparicio

Figma link

#175793 #175793

kkurstak commented 6 months ago

Another important question: how it would work with a full table? I'm guessing the number of rows would need to be limited somehow adjusting to the screen resolution, as we'd ideally want the button to be always visible :)

jennypavlova commented 6 months ago

I wonder only about the size of the button - we could make it for the fly-out maybe small size [32px instead of 40px].

@kkurstak Currently, all buttons have the same size so we can think about changing it everywhere if we want to do that and keep them consistent. wdyt? My concern was that all the buttons are on the top of the content {Examples}

image image image image

if the position is fine in this case I think we can go with implementing that and if we want to do a button redesign to do it everywhere we use the feature feedback button.

jennypavlova commented 6 months ago

Another important question: how it would work with a full table? I'm guessing the number of rows would need to be limited somehow adjusting to the screen resolution, as we'd ideally want the button to be always visible :)

Good question - I see there is pagination there but I am not sure what is the max size of the table

MiriamAparicio commented 6 months ago

I have a question, we already have the feedback button in the anomalies flyout when opening the Anomaly detection link, do we also need it on the asset details flyout?

jennypavlova commented 6 months ago

do we also need it on the asset details flyout?

Good question! That's something @roshan-elastic defines as he knows better where the users should be able to give feedback

kkurstak commented 6 months ago

Hey @jennypavlova - I would like all the buttons to be the same - I think in one environment I saw a smaller sized button, so this has confused me - maybe that was an error. They should all be the same.

As for the location - I agree we have them mainly on top. And that would make sense, but from what I understand, the feedback form is needed only on the 'Anomalies' tab - so it should be located under the tab names. @roshan-elastic could you confirm? Or am I not right Jenny?

jennypavlova commented 6 months ago

As for the location - I agree we have them mainly on top. And that would make sense, but from what I understand, the feedback form is needed only on the 'Anomalies' tab - so it should be located under the tab names. @roshan-elastic could you confirm? Or am I not right Jenny?

I guess it's fine for this specific case as I also don't have a better suggestion for the position in this tab ( Yes that's true it's only for the 'Anomalies' tab 👍 )

kkurstak commented 6 months ago

Yeah, if it's only the tab - I've tried all possible positions on Figma, they all looked bad. If the frequency of the answers is very bad, we can rethink it.

roshan-elastic commented 6 months ago

I have a question, we already have the feedback button in the anomalies flyout when opening the Anomaly detection link, do we also need it on the asset details flyout?

Hey @MiriamAparicio @kkurstak, good question! My thinking here is that the feedback link in the dedicated anomaly detection fly-out will be hit mainly by users who are trying to onboard anomaly detection. The anomaly detection tab in the resource view fly-out would be more used by users who are looking for the actual anomalies (I have some telemetry in this issue which shows good demand for the anomaly detection tab).

I think we'd need it in both so we capture both (a) users who are trying to onboard (b) users who are actively trying to use it.

Recap

Just trying to catch up with where we are here...it seems that we've completed an issue to show the feedback link in the AD fly-out, we're just figuring out where to put a form link in the AD tab in the resource view fly-out?

i.e. as per @kkurstak's design

Are we OK to proceed on that basis or do you need any more input from me?

cc @jennypavlova