elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.58k stars 8.09k forks source link

[Alert details page] Link dashboards to alerts #175884

Closed benakansara closed 1 week ago

benakansara commented 7 months ago

Based on POC done during ON week, we would like to implement functionality of linking dashboards to the alerts.

POC

https://github.com/elastic/kibana/assets/69037875/cae4f9f6-711b-4105-a0e6-676ffc7cfd2f

Screenshot 2024-01-29 at 11 56 56
elasticmachine commented 7 months ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

jasonrhodes commented 5 months ago

@benakansara can you explain to me (on Zoom is fine) how the list of dashboards is populated for the user to choose from? It would be good to roughly outline that as part of the "acceptance criteria" for this issue.

benakansara commented 5 months ago

@jasonrhodes In the POC, I got list of dashboards from saved objects. All the dashboards created by user will be populated in the dropdown.

There was a discussion around using "tags". We could skip the dropdown of dashboards in rule form and directly link dashboards which has same tags as defined in rule. That way user doesn't need to select dashboards from the list.

What do you think would be a better approach? Based on the approach we decide, I will update the acceptance criteria on the ticket.

jasonrhodes commented 5 months ago

Good question. I'm going to try to see what @roshan-elastic is thinking from his side of things and see if we can partially align on the direction being taken in other parts of Observability. I'm going to try to get some answers around that quickly so we can get clarity on how to get this to our customers ASAP. Thanks!

jasonrhodes commented 5 months ago

@elastic/kibana-presentation team mentioned that there is a <DashboardPicker> component but that it's very simple and would need some extensions if we want it to "search by tag" for example. Adopting something like that for any observability use-case could be a good way to stay aligned but also allow us to move forward. I'll check with Roshan and come back to this thread soon.

benakansara commented 5 months ago

I came to know about this component later when talking to @maciejforcone. It would be good to reuse this component and extend it for our use case, so the UX is consistent across kibana wherever this component is used.

jasonrhodes commented 5 months ago

Here is a current design issue re: adding dashboards to a host view https://github.com/elastic/observability-dev/issues/3302

This functionality already exists for APM services, as well. In both cases, they use a separate "tab" on the view, called "Dashboards". In the tab, you can link dashboards via a search widget. I think it'd be great to adopt that same language for our view, but as I understand it, I don't think our alert details pages use tabs of any kind at the moment. So that sounds like a bigger change.

A few things to sort out with this POC is what happens if the user selects 30 dashboards, the list would blow out the design, so we'd need some kind of truncation limit there, probably. @maciejforcone can we look at this briefly together next week and see if we can outline a multi-step plan for unblocking this without diverging too wildly from other planned designs similar to this idea? I'll schedule something.

jasonrhodes commented 1 week ago

@benakansara is going to create a new ticket for this work, as it is currently planned now.