elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.73k stars 8.14k forks source link

[Observability Onboarding] Set up separate serverless landing page behind cloud experiment flag #178942

Closed flash1293 closed 5 months ago

flash1293 commented 6 months ago

:notebook: Summary

When a newly introduced cloud experiment flag is set, instead of the existing tile based landing page, app/observabilityOnboarding should render an empty placeholder page.

If it's not possible to keep the new landingpage behind a feature flag, most of the new functionality, needs to be kept on a feature branch until the basic experience is ready.

:heavy_check_mark: Acceptance criteria

Implementation note

Currently, launchdarkly is not enabled on serverless - see https://github.com/elastic/kibana-controller/issues/316 Anticipating that it will be available soon, we will build the landingpage branch based on the cloud experiment service.

Experiments service documentation: https://docs.elastic.dev/kibana-dev-docs/key-concepts/cloud-experiments-plugin

If it becomes apparent close to the target release date that launchdarkly won't be available, the new landing page will be shown in all cases.

elasticmachine commented 6 months ago

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

justinkambic commented 6 months ago

The new landing page is also targeted specifically at Serverless projects, correct? So the new landing scaffold should show in the case that the feature flag is enabled, and Kibana's build flavor is Serverless.

Are we able to abstract the environment difference into the feature flag? Meaning, in Launch Darkly if we're able to stipulate that the flag should only run in Serverless Kibana we wouldn't need to add this dependency into the Kibana code. I will start out just adding the flag dependency as the issue specifies.

flash1293 commented 6 months ago

I think we should get the "isServerless" flag from the cloud plugin (should be part of the contract) and only use the cloud experiments feature flag if we are in a serverless context

flash1293 commented 6 months ago

Otherwise we always go for the existing tile based landing page (ESS and self-managed)

justinkambic commented 6 months ago

only use the cloud experiments feature flag if we are in a serverless context

Ok, I will make this modification. I've already pushed this to the feature flag, but probably should've pushed an empty branch and made a PR so we could review. Sorry about that.