elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.7k stars 8.12k forks source link

[Dashboard] Interactive "Managed" badge #179152

Closed flash1293 closed 2 weeks ago

flash1293 commented 5 months ago

I tried to click the "Managed" badge multiple times thinking it would trigger the Clone so I can edit the dashboard (or give me a context menu to do so):

Screenshot 2024-03-21 at 14 27 11

The current flow of this feels a little weird to me - you need to hover over the badge to learn that you need to click the other button two menu points over.

Clicking the badge should either directly trigger the Cloning process (needs to be described in the tooltip in this case: Click here to clone this dashboard for editing) or open a modal or context menu or something similar where I can trigger the clone.

The current UI "teaches" the user what the Clone button does in a way, but it doesn't feel natural to me.

elasticmachine commented 5 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

teresaalvarezsoler commented 4 months ago

I agree the cloning experience for managed dashboards can be improved

Clicking the badge should either directly trigger the Cloning process

but I'm afraid if we do this, it will only lead to more mistakes like this https://github.com/elastic/kibana/issues/181258

open a modal or context menu or something similar where I can trigger the clone

this can also be super annoying if users are only looking for information and they click by mistake

flash1293 commented 4 months ago

but I'm afraid if we do this, it will only lead to more mistakes like this https://github.com/elastic/kibana/issues/181258

I'm definitely in favor of some kind of confirmation step in there.

this can also be super annoying if users are only looking for information and they click by mistake

Not sure I'm following here, why would they click it by accident? The tooltip would clearly state what the click behavior is - right now it doesn't do anything.

Heenawter commented 4 months ago

I'm not sure I love the idea of the badge itself containing the clone action - tooltips don't tend to be very accessible, and it could be super easy to miss.

Instead, I wonder if it would be better to have a popover that is opened when the badge is clicked which would give users the option to clone. At that point, I think it would be okay to skip the confirmation step (unless we decide that renaming the cloned Dashboard is important, as we already discussed in https://github.com/elastic/kibana/issues/161047)

this can also be super annoying if users are only looking for information and they click by mistake

Hiding the clone action in the popover would also make this less likely :+1: Not a big deal to have a popover opened if you accidentally click the badge; opening a modal and/or auto-cloning on click is a lot more obtrusive.

flash1293 commented 4 months ago

+1 for the popover opening when the badge is clicked @Heenawter

teresaalvarezsoler commented 4 months ago

+1 for that solution