search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.64k stars 8.23k forks source link

[ES|QL] add telemetry for editor events #180492

Open drewdaemon opened 7 months ago

drewdaemon commented 7 months ago

A few things I'd like to know

elasticmachine commented 7 months ago

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon commented 7 months ago

Impact medium (at least?) because completing this task will help us do more accurate impact assessments of all the other issues.

stratoula commented 7 months ago

Yes! I will also add this to the 8.15 list

drewdaemon commented 7 months ago

@ninoslavmiskovic anything you'd add to the list?

ninoslavmiskovic commented 7 months ago

I have in previous iterations added a list to @stratoula , but we didn't add more telemetry because of performance. I will share the document with you separately 😊 some of your events are in there.

There are some other events in the document that could be useful but not connected to the editor.

In general I would like us to have telemetry on the same importance as testing when building new features.

stratoula commented 7 months ago

There are very specific things we want to add in telemetry with Drew, there are things we can't measure with fullstory. So our lists are different Nino. When we start working on this list we can send you a list of the things we are adding but there are not things we can measure with fullstory

ninoslavmiskovic commented 7 months ago

Sounds like a plan 👍

stratoula commented 1 month ago

@drewdaemon can you elaborate on this?

Performance of the editor

drewdaemon commented 1 month ago

Performance of the editor

can you elaborate on this?

Well, it was a few months ago... so I'm just guessing at what I was thinking. We collect dashboard performance data, so why not the editor performance data? Or maybe it isn't worth it. But that's the discussion to have I suppose.

stratoula commented 1 month ago

Yes it sounds interesting but if we cant think of how it will work it is mostly causing confusion. I removed it from the list for now (unless we think something that makes sense) and added another entry for the recommended queries.

Last but not least do you remember what you had in mind on this? Suggestion acceptance rate

drewdaemon commented 1 month ago

Last but not least do you remember what you had in mind on this? Suggestion acceptance rate

Yes. How often users accept a suggestion from the menu. Sort of a proxy for the quality of the suggestions we're making.

stratoula commented 1 month ago

Awesome thanx!