elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.48k stars 8.05k forks source link

[Discover] Handle text based (ES|QL) query checks consistently in Discover #181639

Open davismcphee opened 2 months ago

davismcphee commented 2 months ago

Currently in Discover we use a few different methods of checking if a query is text based (ES|QL):

We also use different variable names for the result which is confusing:

We should align on a single method of checking for text based / ES|QL queries and use consistent naming. Possibly something including ES|QL for clarity, along these lines: const isEsqlQuery = isEsqlQueryType(query).

elasticmachine commented 2 months ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)