elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.5k stars 8.06k forks source link

[Discover] Smart Fields #181674

Open Kerry350 opened 2 months ago

Kerry350 commented 2 months ago

Summary

Smart Fields (originally implemented here: https://github.com/elastic/kibana/pull/177626) should be migrated to the Discover codebase, this includes the actual virtual columns code (e.g. for resource and content) as we need to be able to render and display those fields if they are selected.

For the initial version of this code pushdown we will lean on the current customisation framework to say "yes, render logs fields". This will only be a temporary stopgap until the data type contextual awareness is live in Discover.

Reviews

(See also tasklist)

Bugs

Either in the initial PR or followup PRs we should also fix bugs caused by Smart Fields:

Acceptance Criteria:

Image reference:

Image Image

### Tasks
- [x] [Part one] Move code to Discover (with temporary / rudimentary context decisions based on current extension framework).
- [ ] [Part two] Hook up data type decisions to the new context awareness once implemented.
- [ ] [Part three] Amend tests (functional tests that exist in Logs Explorer should move to Discover once context awareness lands)
- [x] [Part four] Fix bugs (see description)
- [ ] [Part five] Follow up on async chunk size increases in https://github.com/elastic/kibana/pull/184172
elasticmachine commented 2 months ago

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)