[i18n] Missing translation

[Heenawter]

Describe the bug: Despite existing in the Kibana codebase for 4 years, the following translations are missing:

• core.overlays.confirm.cancelButton
• core.overlays.confirm.okButton

This is causing a bug in Dashboard (and anywhere where the overlay service's openConfirm is used) where, if a manual translation is not provided, the buttons are not translated:

(In the above screenshot, custom Confirm text was provided but custom Cancel text was not). Considering how long ago this code was added, I'm assuming these translations somehow fell through the cracks.

Steps to reproduce:

1. Change the default language to 'zh-CN' in kibana.yml and launch Kibana
2. Open a dashboard and cause unsaved changes
3. Hit the reset button and notice that the Cancel button is not being translated despite being passed through the i18n service with the following key: core.overlays.confirm.cancelButton

Expected behavior: Both the Cancel and Confirm buttons should be translated without the consumer of openConfirm having to provide them - they should only need to provide them if they want custom text

More screenshots:

• When deleting a dataview:

  

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[afharo]

I found the reason for the missing translations: Our message extractor checks for the explicit patterns i18n('a.message') or i18n.translate('a.message') (relevant code).

Any places renaming i18n to something else are not caught by our script 🙈 .

Using the regexes \s(?!i18n\.translate)\w+\.translate\( and import { i18n as I found all these occurrences (there might be more, though):

• package/core/overlays:
  • https://github.com/elastic/kibana/blob/704e080c93474d67b35e7d7a63fb0358500f40a5/packages/core/overlays/core-overlays-browser-internal/src/modal/modal_service.tsx#L141
  • https://github.com/elastic/kibana/blob/704e080c93474d67b35e7d7a63fb0358500f40a5/packages/core/overlays/core-overlays-browser-internal/src/modal/modal_service.tsx#L146
• src/plugins/management:
  • https://github.com/elastic/kibana/blob/37dee75e3122ba8cf818e957fe84b1f0bf8343cc/src/plugins/management/public/plugin.tsx#L95
  • https://github.com/elastic/kibana/blob/37dee75e3122ba8cf818e957fe84b1f0bf8343cc/src/plugins/management/public/plugin.tsx#L98
  • https://github.com/elastic/kibana/blob/37dee75e3122ba8cf818e957fe84b1f0bf8343cc/src/plugins/management/public/plugin.tsx#L111
• x-pack/packages/kbn-elastic-assistant:
  • https://github.com/elastic/kibana/blob/b20ca748214302131ffd510528a4b6a0961b9fc9/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor_flyout/index.tsx#L85
  • https://github.com/elastic/kibana/blob/b20ca748214302131ffd510528a4b6a0961b9fc9/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor_flyout/index.tsx#L93
• x-pack/observability_solution/synthetics:
  • https://github.com/elastic/kibana/blob/3aa41121f6efcbb00b840ce6c020944bfab599e6/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/render_app.tsx#L58
• x-pack/observability_solution/uptime:
  • https://github.com/elastic/kibana/blob/bfc91b0cb035b39916a5efc64ace31e88a230ec5/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/app/render_app.tsx#L58
• x-pack/plugins/security_solution:
  • https://github.com/elastic/kibana/blob/f0719ac33a87c696594c9c5451dbac0e2e82a983/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.tsx#L597
  • https://github.com/elastic/kibana/blob/f0719ac33a87c696594c9c5451dbac0e2e82a983/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/index.tsx#L608
  • https://github.com/elastic/kibana/blob/59845dc5b8a861b024c2fe8f2de1a455327adae2/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/legacy_url_conflict_callout.tsx#L29
  • https://github.com/elastic/kibana/blob/59845dc5b8a861b024c2fe8f2de1a455327adae2/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/use_redirect_legacy_url.ts#L28
  • https://github.com/elastic/kibana/blob/b67d45b3d2485485fa111f814f8c80934ba1df30/x-pack/plugins/security_solution/public/exceptions/components/create_shared_exception_list/index.tsx#L129
• x-pack/plugins/transform:
  • https://github.com/elastic/kibana/blob/bfc91b0cb035b39916a5efc64ace31e88a230ec5/x-pack/plugins/transform/public/plugin.ts#L69

As a quick fix, we could revisit all those usages to follow the expected pattern. But we need to find a way to fix the script.

cc @Bamieh