[Security Solution][Alert details] - extract panel keys to constant file to avoid weird webpack issue (circular dependency?)

PhilippeOberti commented 1 week ago

Summary

While making a very small change to the note_previews component (see pending PR), I noticed some jest tests failing. Those tests seem to be completely unrelated to the changes made in the PR... After investigation, the issues comes from the DocumentDetailsRightPanelKey constant that we import. There must be some sort of circular dependency, or something Webpack isn't happy about...

This current PR only extracts those constants to a separate file. This fixes the jest tests failing in the PR mentioned above. Absolutely no code changes are implemented, other than extracting the constants and updating all the imports.

Will help merge this, so indirectly addresses this bug

elasticmachine commented 1 week ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 3ec29d891b9f929b03ce5692a7b34ec854e3fc2b

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	5458	5459	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	17.4MB	16.8MB	-604.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	82.7KB	82.7KB	-14.0B

Unknown metric groups

#### async chunk count | id | [before](https://github.com/elastic/kibana/commit/13a968a447a4154c0b4579e3ece760ff07cc6bf8) | [after](https://github.com/elastic/kibana/commit/3ec29d891b9f929b03ce5692a7b34ec854e3fc2b) | diff | | --- | --- | --- | --- | | `securitySolution` | 93 | 92 | -1 |

History

:broken_heart: Build #206435 failed bd93acac276dead8450a35500b9a283a8b744f1d
:broken_heart: Build #206405 failed a22bf3f45a9c6a32e559e2da8f06c528270903fc

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 week ago

💔 All backports failed

Status	Branch	Result
❌	8.14	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 181894

Questions ?

Please refer to the Backport tool documentation

PhilippeOberti commented 1 week ago

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

elastic / kibana