[ES|QL] highlighting is incorrect when the error comes from the server

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.33k stars 7.97k forks source link

[ES|QL] highlighting is incorrect when the error comes from the server #181902

Open drewdaemon opened 1 week ago

drewdaemon commented 1 week ago

Kibana version: 8.14

When a user submits a query and gets an error from Elasticsearch, we try to highlight the relevant bit. But, we often fail and the highlight shows up in seemingly-random places.

A couple of examples

from kibana_sample_data_logs | eval abs(@timestamp) | limit 10

from kibana_sample_data_logs | limit 23408239482038

elasticmachine commented 1 week ago

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon commented 1 week ago

I was on the fence between impact:low and impact:medium. This bug doesn't prevent the user from seeing the message and figuring out what went wrong. But I could definitely see it being confusing...