elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.33k stars 7.97k forks source link

[data visualizer] fix clicking field statistics 'Explore in maps' button does not take users to maps #181903

Closed nreese closed 1 week ago

nreese commented 1 week ago

Fixes https://github.com/elastic/kibana/issues/181900

PR resolves issue by

  1. strongly typing triggerOptions to VisualizeFieldContext so future type changes to VisualizeFieldContext will be picked up by this file
  2. Add more protection to visualizeGeoFieldAction.isCompatible method to prevent executing invalid context.

Out of scope for PR - updating "field statistics" to not show "Explore in maps" when action compatibility check fails. visualizeGeoFieldAction.isCompatible is async while getActions is sync.

test

  1. install sample web logs
  2. Open discover
  3. Change data table view to field statistics by clicking "Field statistics" toggle.
  4. Click "Explore in maps" action button for field geo.coordinates.
  5. Verify map is opened showing geo.coordinates
nreese commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/kibana-presentation (Team:Presentation)

qn895 commented 1 week ago

Tested and LGTM 🎉 I'll handle the visualizeGeoFieldAction.isCompatible logic in this PR after this PR is merged.

nreese commented 1 week ago

@elasticmachine merge upstream

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 659.5KB 659.5KB +4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 50.5KB 50.5KB +38.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation