Closed nreese closed 1 week ago
/ci
Pinging @elastic/kibana-presentation (Team:Presentation)
Tested and LGTM 🎉 I'll handle the visualizeGeoFieldAction.isCompatible
logic in this PR after this PR is merged.
@elasticmachine merge upstream
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
dataVisualizer |
659.5KB | 659.5KB | +4.0B |
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
maps |
50.5KB | 50.5KB | +38.0B |
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
Status | Branch | Result |
---|---|---|
✅ | 8.14 |
Note: Successful backport PRs will be merged automatically after passing CI.
Please refer to the Backport tool documentation
Fixes https://github.com/elastic/kibana/issues/181900
PR resolves issue by
triggerOptions
toVisualizeFieldContext
so future type changes toVisualizeFieldContext
will be picked up by this filevisualizeGeoFieldAction.isCompatible
method to prevent executing invalid context.Out of scope for PR - updating "field statistics" to not show "Explore in maps" when action compatibility check fails.
visualizeGeoFieldAction.isCompatible
is async whilegetActions
is sync.test
geo.coordinates
.