elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.32k stars 7.97k forks source link

[ML] Data Frame Analytics functional tests: ensure consistent testing of ROC chart in results #181915

Closed alvarezmelissa87 closed 1 week ago

alvarezmelissa87 commented 1 week ago

Summary

Fixes https://github.com/elastic/kibana/issues/176938 Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5783

In ML data_frame_analytics.x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts

The assertColorsInCanvasElement has ongoing flakiness because of color variation dependent on then environment in which the test is run. Due to this, the specific color check for this particular test suite has been replaced with a basic chart check.

The color assertion is less flaky in the other types of DFA creation so this case is still covered by those tests.

Checklist

elasticmachine commented 1 week ago

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87 commented 1 week ago

@elasticmachine merge upstream

qn895 commented 1 week ago

LGTM 🎉

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @alvarezmelissa87