elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.33k stars 7.97k forks source link

[data.search] Fix format of CCS timed out responses #181919

Closed lukasolson closed 6 days ago

lukasolson commented 1 week ago

Summary

@jughosta noticed in https://github.com/elastic/kibana/pull/179679#issuecomment-2079492811 that when modifying the response format after we hit a time out, we weren't properly setting the timed_out flag to true on the entire response object, just on the individual clusters. This PR fixes that behavior.

Checklist

lukasolson commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kibana-ci commented 6 days ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.5KB 418.5KB +13.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @lukasolson