[TASK][Security Serverless]: Add semantic headings to Fleet Integration forms

1Copenut commented 1 week ago

Summary

refactored the Fleet "Add Integration" form to properly nest headings by level. This improves the experience for screen reader users and helps us improve our standing against WCAG SC 1.3.1 - Info and Relationships (Level A). Screenshot attached below.

Local refactor with nested heading levels

Related issues

Please see the related issue link below. This issue originated from an accessibility review of the Security Serverless project.

Checklist

Delete any items that are not applicable to this PR.

[x] Unit or functional tests were updated or added to match the most common scenarios
[x] Flaky Test Runner was used on any tests changed
[x] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
[x] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
[x] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
[x] This was checked for cross-browser compatibility

For maintainers

[ ] This was checked for breaking API changes and was labeled appropriately

1Copenut commented 1 week ago

Buildkite test this

elasticmachine commented 1 week ago

Pinging @elastic/fleet (Team:Fleet)

kibana-ci commented 1 week ago

:yellow_heart: Build succeeded, but was flaky

Buildkite Build
Commit: e385170dde77946e173c34947e2c4256b358d138

Failed CI Steps

FTR Configs #83

Test Failures

[job] [logs] FTR Configs #83 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.3MB	1.3MB	+48.0B

History

:yellow_heart: Build #206478 was flaky 04082d2ab9d941486e877be9feb57f10fbe2ad80

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @1Copenut

1Copenut commented 1 week ago

I've run the Flaky Test Runner a couple of times on flaky FTR suites to make sure I hadn't introduced issues. Both runs passed with 0 issues, and failures were outside the changeset I created. Going to go ahead and merge this PR.

elastic / kibana