search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.33k stars 7.97k forks source link

[Global] Remove usage of deprecated modules for mounting React #181924

Open tsullivan opened 1 week ago

tsullivan commented 1 week ago

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

tsullivan commented 1 week ago

/ci

tsullivan commented 1 week ago

/ci

kibana-ci commented 1 week ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1675 1691 +16
cloudSecurityPosture 438 452 +14
console 248 252 +4
dashboard 446 447 +1
devTools 30 42 +12
eventAnnotationListing 509 523 +14
filesManagement 139 153 +14
fleet 998 1012 +14
grokdebugger 28 40 +12
indexManagement 652 656 +4
infra 1466 1476 +10
metricsDataAccess 264 274 +10
observabilityOnboarding 239 255 +16
observabilityShared 199 213 +14
osquery 336 346 +10
painlessLab 32 44 +12
runtimeFields 17 33 +16
searchprofiler 78 90 +12
timelines 121 137 +16
total +221

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-table-list-view-table 33 30 -3
timelines 196 197 +1
total -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +3.4KB
cloudSecurityPosture 452.1KB 453.3KB +1.2KB
console 441.2KB 440.8KB -404.0B
dashboard 397.1KB 397.2KB +21.0B
data 46.8KB 46.7KB -123.0B
devTools 5.5KB 6.9KB +1.4KB
eventAnnotationListing 198.5KB 199.6KB +1.1KB
exploratoryView 181.2KB 181.2KB +3.0B
filesManagement 90.5KB 91.5KB +1004.0B
fleet 1.3MB 1.3MB -589.0B
graph 387.4KB 387.3KB -91.0B
grokdebugger 8.7KB 10.1KB +1.4KB
indexManagement 656.2KB 656.4KB +161.0B
infra 1.5MB 1.5MB -25.0B
kubernetesSecurity 213.9KB 214.1KB +182.0B
maps 2.9MB 2.9MB +1.1KB
metricsDataAccess 83.4KB 84.4KB +991.0B
observabilityOnboarding 301.0KB 304.5KB +3.4KB
observabilityShared 54.9KB 56.0KB +1.1KB
osquery 1.0MB 1.0MB -491.0B
painlessLab 16.2KB 17.6KB +1.5KB
profiling 407.9KB 407.9KB -27.0B
searchprofiler 158.8KB 160.2KB +1.4KB
slo 720.3KB 720.3KB -3.0B
synthetics 1.0MB 1.0MB +48.0B
threatIntelligence 57.1KB 57.4KB +359.0B
timelines 30.3KB 31.9KB +1.7KB
uptime 468.1KB 468.1KB +16.0B
visualizations 273.6KB 273.5KB -63.0B
total +19.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 16.0KB 16.0KB +52.0B
console 32.9KB 32.8KB -169.0B
data 417.5KB 417.6KB +102.0B
devTools 11.1KB 11.0KB -82.0B
eventAnnotationListing 10.7KB 10.6KB -21.0B
filesManagement 3.7KB 3.6KB -73.0B
fleet 159.9KB 161.3KB +1.4KB
grokdebugger 4.3KB 4.5KB +173.0B
indexManagement 42.3KB 42.4KB +106.0B
infra 102.5KB 103.5KB +1001.0B
maps 50.5KB 50.6KB +124.0B
metricsDataAccess 56.8KB 56.8KB +68.0B
observabilityOnboarding 6.6KB 6.7KB +124.0B
osquery 51.1KB 52.7KB +1.6KB
painlessLab 10.0KB 10.2KB +194.0B
runtimeFields 11.0KB 12.9KB +1.9KB
searchprofiler 18.8KB 18.8KB +3.0B
timelines 108.9KB 109.2KB +281.0B
total +6.8KB
Unknown metric groups #### API count | id | [before](https://github.com/elastic/kibana/commit/957ff083c4e0c738d8d0b2ae81ae468c3a1abb7b) | [after](https://github.com/elastic/kibana/commit/03cdcc47b71f893112c1775e360514cb6c026a80) | diff | | --- | --- | --- | --- | | `@kbn/content-management-table-list-view-table` | 50 | 46 | -4 | | `timelines` | 240 | 241 | +1 | | total | | | -3 | #### References to deprecated APIs | id | [before](https://github.com/elastic/kibana/commit/957ff083c4e0c738d8d0b2ae81ae468c3a1abb7b) | [after](https://github.com/elastic/kibana/commit/03cdcc47b71f893112c1775e360514cb6c026a80) | diff | | --- | --- | --- | --- | | `apm` | 30 | 27 | -3 | | `cloudSecurityPosture` | 9 | 4 | -5 | | `console` | 5 | 1 | -4 | | `crossClusterReplication` | 2 | 1 | -1 | | `dashboard` | 28 | 24 | -4 | | `data` | 29 | 17 | -12 | | `devTools` | 3 | 0 | -3 | | `eventAnnotationListing` | 2 | 0 | -2 | | `filesManagement` | 6 | 1 | -5 | | `fleet` | 83 | 55 | -28 | | `graph` | 63 | 61 | -2 | | `grokdebugger` | 1 | 0 | -1 | | `indexManagement` | 2 | 0 | -2 | | `infra` | 4 | 1 | -3 | | `maps` | 33 | 25 | -8 | | `metricsDataAccess` | 3 | 0 | -3 | | `observabilityOnboarding` | 4 | 1 | -3 | | `observabilityShared` | 2 | 0 | -2 | | `osquery` | 22 | 9 | -13 | | `painlessLab` | 7 | 3 | -4 | | `runtimeFields` | 3 | 0 | -3 | | `searchprofiler` | 7 | 3 | -4 | | `timelines` | 2 | 0 | -2 | | `visualizations` | 62 | 60 | -2 | | total | | | -119 | #### Unreferenced deprecated APIs | id | [before](https://github.com/elastic/kibana/commit/957ff083c4e0c738d8d0b2ae81ae468c3a1abb7b) | [after](https://github.com/elastic/kibana/commit/03cdcc47b71f893112c1775e360514cb6c026a80) | diff | | --- | --- | --- | --- | | `kibanaReact` | 2 | 3 | +1 |

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream