search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.32k stars 7.97k forks source link

[ML] Decouple data_visualizer from MapEmbeddable #181928

Closed nreese closed 6 days ago

nreese commented 1 week ago

Part of https://github.com/elastic/kibana/issues/182020

test instructions

  1. install web logs sample data
  2. Open discover
  3. In table, click "Field statistics"
  4. Expand geo.dest row. Verify choropleth map is displayed.
  5. Expand geo.coordinates row. Verify vector map is displayed.
nreese commented 1 week ago

/ci

nreese commented 1 week ago

/ci

nreese commented 1 week ago

/ci

nreese commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/ml-ui (:ml)

elasticmachine commented 1 week ago

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese commented 1 week ago

@elasticmachine merge upstream

qn895 commented 1 week ago

Tested and LGTM 🎉

nreese commented 6 days ago

@elasticmachine merge upstream

kibana-ci commented 6 days ago

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataVisualizer 651 644 -7
maps 1178 1182 +4
total -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 274 276 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 658.5KB 656.2KB -2.3KB
maps 3.0MB 3.0MB +6.5KB
total +4.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
maps 31 32 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 24.0KB 23.9KB -134.0B
maps 50.7KB 51.4KB +691.0B
total +557.0B
Unknown metric groups #### API count | id | [before](https://github.com/elastic/kibana/commit/d8831961e868587deb9e72b0c135837977ad6199) | [after](https://github.com/elastic/kibana/commit/58339150c9063e2d570c511233bf73b7b2d29aa0) | diff | | --- | --- | --- | --- | | `maps` | 275 | 281 | +6 | #### async chunk count | id | [before](https://github.com/elastic/kibana/commit/d8831961e868587deb9e72b0c135837977ad6199) | [after](https://github.com/elastic/kibana/commit/58339150c9063e2d570c511233bf73b7b2d29aa0) | diff | | --- | --- | --- | --- | | `maps` | 28 | 30 | +2 | #### ESLint disabled line counts | id | [before](https://github.com/elastic/kibana/commit/d8831961e868587deb9e72b0c135837977ad6199) | [after](https://github.com/elastic/kibana/commit/58339150c9063e2d570c511233bf73b7b2d29aa0) | diff | | --- | --- | --- | --- | | `dataVisualizer` | 72 | 67 | -5 | | `maps` | 52 | 54 | +2 | | total | | | -3 | #### Total ESLint disabled count | id | [before](https://github.com/elastic/kibana/commit/d8831961e868587deb9e72b0c135837977ad6199) | [after](https://github.com/elastic/kibana/commit/58339150c9063e2d570c511233bf73b7b2d29aa0) | diff | | --- | --- | --- | --- | | `dataVisualizer` | 73 | 68 | -5 | | `maps` | 79 | 81 | +2 | | total | | | -3 |

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream