[SLO] Move overview embeddable to new react registry

mgiota commented 1 week ago

Fixes https://github.com/elastic/kibana/issues/179296

🍒 Summary

This PR converts the SLO Overview embeddable (Single SLO & Grouped SLOs) to the new React Embeddable framework. There are no UI changes to the current embeddable and the behavior should be the same. I have a video of how the embeddable should work.

https://github.com/elastic/kibana/assets/2852703/d37c3f99-3140-4a09-a223-36a1d2242649

✔️ Acceptance criteria

A new create_overview_panel_action action is created, which adds the SLO Overview option in the Add panel section
The SLO Overview menu option is grouped under SLOs menu
Clicking on the single SLO card should open a Flyout with the SLO details
Clicking on the Grouped SLOs should expand the accordion and show the SLOs that belong to this group
The Grouped SLO have the Edit criteria option
Edit criteria option appears under More panel options only for the Grouped SLOs
Kibana screenshot tool should report no timeout error.
Clicking on the Refresh button should reload the embeddable
We should be able to set default dimensions to the embeddable panels cc @nickpeihl
- Depends on https://github.com/elastic/kibana/pull/182120

apmmachine commented 1 week ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `elasticsearch-ci/docs` : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine commented 1 week ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

mgiota commented 5 days ago

@elasticmachine merge upstream

mgiota commented 5 days ago

@shahzad31 What issues did you find? Is it about the blank embeddable panel that was caused after synchronizing with main? Issue was caused because of KibanaThemeProvider. My solution to remove it is fine, you can check relevant discussion here

mgiota commented 5 days ago

@sebelga Every approval is more than welcome :-)

kibana-ci commented 5 days ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 8903ae0a2489f519b12dcce1346889919f2948f0
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-181930-8903ae0a2489
Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`slo`	749	752	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`slo`	733.9KB	765.5KB	+31.6KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5407	+5407
`total size`	-	9.1MB	+9.1MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`slo`	22.6KB	23.0KB	+467.0B

Unknown metric groups

#### async chunk count | id | [before](https://github.com/elastic/kibana/commit/af580c9f92c1dfec74bdac6f4aacf03b9ef0b21d) | [after](https://github.com/elastic/kibana/commit/8903ae0a2489f519b12dcce1346889919f2948f0) | diff | | --- | --- | --- | --- | | `slo` | 25 | 27 | +2 |

History

:broken_heart: Build #207695 failed 63cd8f86e38150cead8fa935acd9241ab19910a2
:broken_heart: Build #207669 failed a5c314d9fc5b0c385df2d590a4a33b32e31de417
:yellow_heart: Build #207490 was flaky d70809142dd847d6f61e4694e89336b8cf0653e4
:green_heart: Build #207399 succeeded 697e6077abe3dede64116bf09a6b031a41cb2a13

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @mgiota

elastic / kibana