Open afharo opened 4 months ago
The promises below might fail in case there's a glitch in ES connection and never retry.
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/plugin.ts#L82
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/plugin.ts#L115
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/add_monitor/add_monitor_api.ts#L262-L269
Is that OK? Should we apply any retry logic?
If we want to retry, p-retry could be a useful utility that's already present in the project.
p-retry
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)
The promises below might fail in case there's a glitch in ES connection and never retry.
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/plugin.ts#L82
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/plugin.ts#L115
https://github.com/elastic/kibana/blob/593d3911728cf68093925836ae2031746c7db6cd/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/add_monitor/add_monitor_api.ts#L262-L269
Is that OK? Should we apply any retry logic?
If we want to retry,
p-retry
could be a useful utility that's already present in the project.