elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Security Solution] Asset criticality assignment modal calls API even when the criticality doesn't change #182334

Open machadoum opened 6 months ago

machadoum commented 6 months ago

Describe the bug: When save is pressed on the asset criticality modal it calls the API even when the criticality didn't change.

Kibana/Elasticsearch Stack version: 8.15 (main)

Steps to reproduce:

  1. Assign an entity criticality to "unassigned"
  2. Save
  3. Assign an entity criticality to "unassigned" again
  4. Save

Current behavior: It will call the delete API which will fail with a 404

Expected behavior: It shouldn't call the API because the criticality level didn't change

Screenshots (if relevant):

Screenshot 2024-05-02 at 10 49 33

Errors in browser console (if relevant): Screenshot 2024-05-02 at 10 55 30

elasticmachine commented 6 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 6 months ago

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

machadoum commented 3 months ago

@jaredburgettelastic I tested it, and the issue is still happening. But it has a very low impact.