Closed saikatsarkar056 closed 3 days ago
@TattdCodeMonkey, @saarikabhasi, @sabarasaba Thank you for the feedbacks. Can I get another round of review?
@saarikabhasi, @TattdCodeMonkey Can I get another round of reviews for this PR? I addressed all the feedbacks. Thank you for help. 🙏
@elasticmachine merge upstream
Fewer modules leads to a faster build time
id | before | after | diff |
---|---|---|---|
enterpriseSearch |
2278 | 2280 | +2 |
indexManagement |
660 | 662 | +2 |
serverlessSearch |
319 | 322 | +3 |
total | +7 |
Total count of every public API that lacks a comment. Target amount is 0. Run
node scripts/build_api_docs --plugin [yourplugin] --stats comments
for more detailed information.
id | before | after | diff |
---|---|---|---|
@kbn/search-api-panels |
74 | 76 | +2 |
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
enterpriseSearch |
2.7MB | 2.7MB | +47.0B |
indexManagement |
662.9KB | 662.9KB | +45.0B |
serverlessSearch |
471.5KB | 476.1KB | +4.6KB |
total | +4.6KB |
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @saikatsarkar056
In this PR, we've incorporated ingest pipeline selection into the "Ingest Data" section for the serverless solution. When a user chooses an ingest pipeline, the corresponding code snippet will adjust accordingly.
Testing steps
Screen-recording
https://github.com/elastic/kibana/assets/132922331/d2f5b74f-91a6-4be2-8323-ee3eda5afa02